Skip to content

docs/user/vsphere/install_upi: Fix [...][#...] references, etc. #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 11, 2019
Merged

docs/user/vsphere/install_upi: Fix [...][#...] references, etc. #2494

openshift-merge-robot merged 1 commit into from
Oct 11, 2019

Conversation

@wking
Copy link
Member

@wking wking commented Oct 10, 2019

Broken since the docs landed in 0ec07d0 (#1545).

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019
@wking wking force-pushed the fix-vsphere-monitor-for-cluster-completion-link branch from e6718da to 6fa36d5 Compare October 10, 2019 20:53
@wking wking changed the title docs/user/vsphere/install_upi: Fix #monitor-for-cluster-completion reference docs/user/vsphere/install_upi: Fix [...][#...] references Oct 10, 2019
@wking wking force-pushed the fix-vsphere-monitor-for-cluster-completion-link branch 2 times, most recently from 0ec6b17 to 999073a Compare October 10, 2019 20:58
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2019
@wking wking changed the title docs/user/vsphere/install_upi: Fix [...][#...] references docs/user/vsphere/install_upi: Fix [...][#...] references, etc. Oct 10, 2019
@wking wking force-pushed the fix-vsphere-monitor-for-cluster-completion-link branch 2 times, most recently from 679cb7f to d46d6d1 Compare October 10, 2019 21:01
@wking
docs/user/(vsphere|metal)/install_upi: Fix [...][#...] references, etc.
fdad481 
Broken since the vSphere docs landed in 0ec07d0 (docs: vSphere
installation docs, 2019-04-07, openshift#1545).  Also a bunch of other broken
links and some minor wordsmithing.
@wking wking force-pushed the fix-vsphere-monitor-for-cluster-completion-link branch from d46d6d1 to fdad481 Compare October 10, 2019 21:02
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 10, 2019

/approve

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 11, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 11, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f0ad4e6 into openshift:master Oct 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2019

@wking: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 6fa36d5bb05581437f8fce181d27ef30bb260313 link /test e2e-openstack
ci/prow/e2e-libvirt 6fa36d5bb05581437f8fce181d27ef30bb260313 link /test e2e-libvirt
ci/prow/e2e-aws 6fa36d5bb05581437f8fce181d27ef30bb260313 link /test e2e-aws
ci/prow/e2e-aws-scaleup-rhel7 fdad481 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking deleted the fix-vsphere-monitor-for-cluster-completion-link branch October 11, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @abhinavdahiya @openshift-ci-robot @openshift-bot @openshift-merge-robot